Support twilio api key #5039
Open
Support twilio api key #5039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louischan-oursky
requested changes
Mar 3, 2025
| AuthToken string `json:"auth_token,omitempty"` | ||
| MessagingServiceSID string `json:"message_service_sid,omitempty"` | ||
| // For write only, always use GetCredentialType to read the value | ||
| CredentialType *TwilioCredentialType `json:"credential_type,omitempty"` |
There was a problem hiding this comment.
Rename this to CredentialType_WriteOnly
| @@ -12,6 +12,7 @@ import ( | |||
| ) | |||
|
|
|||
| type TwilioClientCredentials struct { | |||
| CredentialType *config.TwilioCredentialType | |||
There was a problem hiding this comment.
Use the non-pointer type here.
| var smsProviderTwilioCredentials = graphql.NewObject(graphql.ObjectConfig{ | ||
| Name: "SMSProviderTwilioCredentials", | ||
| Description: "Twilio credentials", | ||
| Fields: graphql.Fields{ | ||
| "credentialType": &graphql.Field{ | ||
| Type: graphql.NewNonNull(twilioCredentialType), | ||
| }, |
There was a problem hiding this comment.
Do we need to write a custom resolver that calls GetCredentialType()?
| @@ -188,16 +192,36 @@ function constructFormState( | |||
| providerType = SMSProviderType.Twilio; | |||
| } | |||
|
|
|||
| let twilioCredentialType: TwilioCredentialType = | |||
| TwilioCredentialType.AuthToken; | |||
There was a problem hiding this comment.
For new credentials, the default should be API key, since it it preferred way to authenticate.
| @@ -65,7 +65,7 @@ var smsProviderConfigurationTwilioInput = graphql.NewInputObject(graphql.InputOb | |||
| Type: graphql.NewNonNull(graphql.String), | |||
| }, | |||
| "apiKeySecret": &graphql.InputObjectFieldConfig{ | |||
| Type: graphql.String, | |||
| Type: graphql.NewNonNull(graphql.String), | |||
There was a problem hiding this comment.
Shouldn't authToken, apiKeySID, apiKeySecret all be nullable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-2513