Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Configurable id, default with form id to avoid duplicated ids #32

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

alvarosabu
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind api-change

What this PR does / why we need it:
Avoid duplicated ids and allow user to configure each input id.

Which issue(s) this PR fixes:

Fixes #31

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation e.g., Vue libraries, usage docs, etc.:


@alvarosabu alvarosabu added enhancement New feature or request feature labels Jun 3, 2020
@alvarosabu alvarosabu added this to the v0.3.0 milestone Jun 3, 2020
@alvarosabu alvarosabu self-assigned this Jun 3, 2020
Copy link

@quicoto quicoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!

@alvarosabu alvarosabu merged commit 0730769 into master Jun 3, 2020
@alvarosabu
Copy link
Collaborator Author

Cool stuff!

no, you're cool @quicoto

@alvarosabu alvarosabu deleted the feature/form_field_id_configurable branch August 17, 2020 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow set input id on FormField
2 participants