Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciidoc-diagram-to-pdf-example #49

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jeffcjohnson
Copy link

This works for saving diagrams to PDF but does not work with static images at the same time.

The copy command doesn't seem to be doing anything.

Jeff Johnson added 3 commits February 7, 2019 18:46
@jeffcjohnson
Copy link
Author

@mojavelinux I have two places in the Gradle build file that try to copy the static images to the build dir but neither seem to work. It might be something I'm doing wrong in Gradle but I also wonder if asciidoc is wiping out $buildDir/asciidoc/pdf/images when it starts up.

Any thoughts?

@mojavelinux
Copy link
Member

If you are using the latest AsciidoctorJ and Asciidoctor Diagram, you should find that the images are now embedded properly without having to set imagesoutdir. It should be automatic now.

For details, see asciidoctor/asciidoctor-pdf#1033. Basically, Asciidoctor Diagram now works out where to put the images so you don't have to tell it how.

- upgrade Asciidoctor PDF
- upgrade Asciidoctor Diagram
- remove image copying logic
- fix attribute names
- use Rouge as syntax highlighter
@mojavelinux
Copy link
Member

I've pushed a commit to your PR that fixes the build.

Before this is merged, I think it makes sense to merge it with the html variant and renaming it to asciidoctor-diagram-example. Can you make that update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants