-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example apps #81
Conversation
5b36d40
to
f18b716
Compare
19d0cb5
to
4cd823e
Compare
Excellent stuff, @damassi! 👏 🙌
Perhaps this should be using yarn workspaces? Because I do think examples should use local code, not published out-of-sync [with local lib] code. |
Agree; can set this up in a follow-up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 These are great!!! They helped me understand the usage a lot.
I left a few very minor suggestions.
3d909a2
to
efad9ab
Compare
efad9ab
to
297ed93
Compare
There’s a broken link here /~https://github.com/artsy/react-responsive-media/pull/81/files#diff-04c6e90faac2675aa89e2176d2eec7d8R317 |
6300976
to
4a792ef
Compare
4a792ef
to
252ba42
Compare
Alright, one more look when y'all get a sec 😄 Addressed remainder of feedback. |
Almost there!! Additionally, I noticed this sentence in the README:
And would like to replace ‘flaws’ with something less loaded. Perhaps something like:
? |
I took the liberty to address my own feedback, so that I could start the rename work. |
Thanks for the review everyone! |
Adds a few more examples to the repo:
/example
folder. I think we should try to steer people to the the basic and bare bones SSR examples first and then the kitchen sink example after. For people who are already familiar with the lib this is the perfect reference doc for whatever they may need but I worry about less advanced users becoming overwhelmed / confused.Todo
interactions
optional #82 is merged, publish new version of fresnel withoutinteractions
requirement and then update examples with pointers to lib rather than../
relative references to code -- babel + ts doesn't like it.(As an aside, I fell in a serious babel / compiler worm hole trying to figure out ^... When using
babel-node
, ornode -r @babel/register
, it's not easy to compile code below the root location whereprocess.cwd()
lives (where node booted up). Things just don't want to work and there is a lot of ambiguity around how to address the issue online... Easier to steer clear 😓 and install from the package when needing to compile stuff server-side.)