-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foundations upgrade #660
Closed
zachgarwood
wants to merge
89
commits into
feature/twill-upgrade
from
feature/twill-foundations-upgrade
Closed
Foundations upgrade #660
zachgarwood
wants to merge
89
commits into
feature/twill-upgrade
from
feature/twill-foundations-upgrade
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Twill 3 upgrade script already uses rector to automate simple changes, we should continue to use it to make our own custom changes - install rector as a dev dependency - create script for updating type compatibility
The exact command was: ./vendor/bin/rector process --clear-cache --config=scripts/rector/twill-3-upgrade-type-compatibility.php
Bumps [@sentry/browser](/~https://github.com/getsentry/sentry-javascript) to 8.50.0 and updates ancestor dependency [@sentry/react](/~https://github.com/getsentry/sentry-javascript). These dependencies need to be updated together. Updates `@sentry/browser` from 8.28.0 to 8.50.0 - [Release notes](/~https://github.com/getsentry/sentry-javascript/releases) - [Changelog](/~https://github.com/getsentry/sentry-javascript/blob/8.50.0/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@8.28.0...8.50.0) Updates `@sentry/react` from 8.28.0 to 8.50.0 - [Release notes](/~https://github.com/getsentry/sentry-javascript/releases) - [Changelog](/~https://github.com/getsentry/sentry-javascript/blob/8.50.0/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@8.28.0...8.50.0) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: indirect - dependency-name: "@sentry/react" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
zachgarwood
force-pushed
the
feature/twill-foundations-upgrade
branch
from
January 16, 2025 22:07
40aff8d
to
f6f967b
Compare
Quality Gate passedIssues Measures |
zachgarwood
changed the base branch from
feature/twill-upgrade
to
feature/twill-guide
January 16, 2025 22:08
nikhiltri
force-pushed
the
feature/twill-guide
branch
from
January 17, 2025 15:54
08b1c3e
to
9594292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade allows for us to start using the shared api / twill model code from Foundations.