WIP Twill index table columns #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Twill 3 upgrade script already uses rector to automate simple changes, we should continue to use it to make our own custom changes - install rector as a dev dependency - create script for updating type compatibility
The exact command was: ./vendor/bin/rector process --clear-cache --config=scripts/rector/twill-3-upgrade-type-compatibility.php
zachgarwood
commented
Jan 14, 2025
|
|
||
| // WEB-1963: Browser for nested modules must be implemented manually | ||
| Route::get('/digitalPublicationsBrowser/articles/browser?digitalPublication={digitalPublication}', [DigitalPublicationArticleController::class, 'browser'])->name('collection.articles_publications.digitalPublications.articles.subbrowser'); | ||
| Route::get('/digitalPublicationsBrowser/articles/browser', [DigitalPublicationArticleController::class, 'browser'])->name('collection.articles_publications.digitalPublications.articles.browserbrowser'); | ||
| Route::get('/digitalPublicationsBrowser/articles/browser', [DigitalPublicationArticleController::class, 'browser'])->name('collection.articles_publications.digitalPublications.articles.browser'); | ||
| }); |
There was a problem hiding this comment.
@nikhiltri this is the only change I didn't recognize from your merge conflict resolutions. Either the reference to this route name needs to be update, or this needs to be reverted.
zachgarwood
force-pushed
the
feature/twill-upgrade
branch
from
ad710ef to
73d5369
Compare
|
nikhiltri
force-pushed
the
feature/twill-upgrade
branch
from
73d5369 to
6cea83e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.