Add upstream LSP tests to CI

.circleci/config.yml

@@ -53,28 +53,12 @@ jobs:
           name: Test
           command: npm run test --  --runInBand
 
-  E2E tests:
-    executor: node
-    steps:
-      - checkout
-      - npm-install
-      - run: sudo apt update &&  sudo apt install -y libasound2 libgbm1 libgtk-3-0 libnss3 xvfb
-      - run:
-          name: Build
-          command: npm run build:production
-      - run:
-          command: echo 'APOLLO_KEY="service:bob-123:489fhseo4"' > ./sampleWorkspace/spotifyGraph/.env
-      - run:
-          name: E2E tests
-          command: xvfb-run -a npm run test:extension
-
 workflows:
   build-test-deploy:
     jobs:
       - lint
       - typescript
       - test
-      - E2E tests
   security-scans:
     jobs:
       - secops/gitleaks:

.github/workflows/E2E.yml

@@ -0,0 +1,27 @@
+name: Run E2E tests
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+jobs:
+  test:
+    name: Run E2E tests
+    runs-on: ubuntu-latest
+    steps:
+      - run: sudo apt update && sudo apt install -y libasound2 libgbm1 libgtk-3-0 libnss3 xvfb expect
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          cache: "npm"
+      - run: npm install
+      - run: npm run build:production
+      - run: echo 'APOLLO_KEY="service:bob-123:489fhseo4"' > ./sampleWorkspace/spotifyGraph/.env
+      - run: |
+          expect <<EOF
+          spawn ./node_modules/.bin/rover config auth --profile VSCode-E2E
+          expect "Copy the key and paste it into the prompt below."
+          send -- "test\n"
+          expect eof
+          EOF
+      - run: xvfb-run -a npm run test:extension

jest.e2e.config.js

@@ -3,6 +3,8 @@ const path = require("path");
 
 module.exports = {
   moduleFileExtensions: ["js", "ts"],
+  // restrict the roots here so jest doesn't complain about *other* snapshots it sees as obsolete
+  roots: ["<rootDir>/src/language-server/__e2e__"],
   testMatch: ["<rootDir>/src/**/*.e2e.ts"],
   testEnvironment: "./src/__e2e__/vscode-environment.js",
   setupFiles: ["./src/__e2e__/setup.js"],