fix importAttributes is not avaliable in old node versions

apollographql · Oct 11, 2024 · 913e6ae · 913e6ae
1 parent 24440fa
commit 913e6ae
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 7 deletions.
diff --git a/src/language-server/config/cache-busting-resolver.js b/src/language-server/config/cache-busting-resolver.js
@@ -3,6 +3,19 @@ const { pathToFileURL } = require("node:url");
 
 /** @import { ResolveContext, ResolutionResult, LoadResult, ImportContext } from "./cache-busting-resolver.types" */
 
+/**
+ * importAssertions was renamed to importAttributes in newer versions of Node.js.
+ *
+ * @param {ResolveContext|ImportContext} context
+ * @returns {"importAttributes"|"importAssertions"}
+ */
+function importAttributesKeyName(context) {
+  if (!("importAttributes" in context) && "importAssertions" in context) {
+    return "importAssertions";
+  }
+  return "importAttributes";
+}
+
 /**
  * @param {string} specifier
  * @returns {string}
@@ -21,14 +34,15 @@ function bustFileName(specifier) {
  * @returns {Promise<ResolutionResult>}
  */
 async function resolve(specifier, context, nextResolve) {
-  if (context.importAttributes.as !== "cachebust") {
+  const importAttributesKey = importAttributesKeyName(context);
+  if (context[importAttributesKey].as !== "cachebust") {
     return nextResolve(specifier, context);
   }
   // no need to resolve at all, we have all necessary information
   return {
     url: bustFileName(specifier),
-    format: context.importAttributes.format,
-    importAttributes: context.importAttributes,
+    format: context[importAttributesKey].format,
+    [importAttributesKey]: context[importAttributesKey],
     shortCircuit: true,
   };
 }
@@ -41,13 +55,14 @@ async function resolve(specifier, context, nextResolve) {
  * @returns {Promise<LoadResult>}
  */
 async function load(url, context, nextLoad) {
-  if (context.importAttributes.as !== "cachebust") {
+  const importAttributesKey = importAttributesKeyName(context);
+  if (context[importAttributesKey].as !== "cachebust") {
     return nextLoad(url, context);
   }
   return {
     format: context.format || "module",
     shortCircuit: true,
-    source: context.importAttributes.contents,
+    source: context[importAttributesKey].contents,
   };
 }
 

diff --git a/src/language-server/config/cache-busting-resolver.types.ts b/src/language-server/config/cache-busting-resolver.types.ts
@@ -19,13 +19,15 @@ type Format =
 
 export interface ResolveContext {
   conditions: string[];
-  importAttributes: ImportAttributes;
+  importAttributes?: ImportAttributes;
+  importAssertions: ImportAttributes;
   parentURL?: string;
 }
 
 export interface ImportContext {
   conditions: string[];
-  importAttributes: ImportAttributes;
+  importAttributes?: ImportAttributes;
+  importAssertions: ImportAttributes;
   format: Format;
 }