Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic options resolve function #335

Merged
merged 5 commits into from
Apr 9, 2017
Merged

generic options resolve function #335

merged 5 commits into from
Apr 9, 2017

Conversation

DxCx
Copy link
Contributor

@DxCx DxCx commented Mar 22, 2017 •
edited by nnance
Loading

will be taken out of #308

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR) - not needed i assume?
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@DxCx DxCx force-pushed the resolve-options branch from 609b0f4 to 5a7477d Compare March 22, 2017 13:16
@DxCx
Copy link
Contributor Author

DxCx commented Mar 26, 2017

@helfer / @stubailo ?

@helfer
Copy link
Contributor

helfer commented Apr 1, 2017

Looks good to me @DxCx! Is this so it can be used with subscriptions more easily?

@DxCx
Copy link
Contributor Author

DxCx commented Apr 1, 2017

Yep

@DxCx
Copy link
Contributor Author

DxCx commented Apr 5, 2017

@helfer?

@nnance nnance merged commit 71c0a62 into apollographql:master Apr 9, 2017
@DxCx DxCx deleted the resolve-options branch April 9, 2017 06:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DxCx @helfer @nnance