-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not cancel server fetch of watcher on dependent key update #1156
Merged
designatednerd
merged 10 commits into
apollographql:master
from
withDouble:florent/cancel_only_when_server_fetch
May 19, 2020
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
08c4a62
Cancel watcher fetch only if new fetch includes server
flobories 84c56e6
One case per line
flobories 08febcb
Improve style
flobories ca136d7
Merge remote-tracking branch 'origin/master' into florent/cancel_only…
flobories ef825e3
Merge branch 'master' into florent/cancel_only_when_server_fetch
flobories 3899f9d
Revert first attempt
flobories 2b07e69
Load from the store before attempting server fetch
flobories bcbb46f
Restore erroneously erased comment
flobories c3f1945
PR Feedback
flobories 9ffce33
Do not retain self strongly in async
flobories File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
.fetchIgnoringCacheData
correct here? it was.returnCacheDataElseFetch
before.Can we get into some fetch cycle here?
fetch(cachePolicy: CachePolicy)
-> Fail ->fetch(cachePolicy: CachePolicy)
-> Fail -> ...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before it was
returnCacheDataElseFetch
because we weren't explicitly trying to load from the cache. By the point this gets hit, we've already checked the cache sofetchIgnoringCacheData
acknowledges that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the
fail
is for reading directly from the store, rather than for hitting the network, so that cycle should not be an issue.