Prevent merging of fragment fields into selection tree if fragment field merging is disabled #571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when fragment field merging is disabled we are preventing the fields from being merged into the
MergedSelections
while traversing the builtEntitySelectionTree
. However, the performance issues described in apollographql/apollo-ios#3434 are actually caused during the merging of the fragment fields into theEntitySelectionTree
s during the building of the operations.This PR prevents the fragment selection trees from being merged into the
EntitySelectionTree
while building the operations if fragment field merging is disabled.This means that the entity trees are actually incomplete, but they still work for the purposes of Codegen in this scenario. Incomplete
EntitySelectionTree
s would cause selection set initializers to be invalid. But this is not a problem because disabling fragment field merging is already incompatible with selection set initializers (and we have a validation step to ensure those options are not used together).