Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make YAxis seriesName an Array #4443

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

j2ghz
Copy link
Contributor

@j2ghz j2ghz commented Apr 29, 2024

#4247 now allows or requires seriesName to be an array, and that wasn't reflected in the types. I wasn't able to find out which case it is, and even the documentation doesn't mention seriesName being an array, in one place it's a string, in another it's undefined.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@j2ghz j2ghz marked this pull request as ready for review April 29, 2024 10:44
@junedchhipa junedchhipa merged commit e7f9f08 into apexcharts:main May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants