Fix issue 4216: grid padding calc to support array of stroke widths #4410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
This commit adjusts the
plotCoords
method to correctly handle cases where the stroke width (stroke.width
) is provided as an array of values, which corresponds to different series in the visualization. Previously, the code assumed a single numeric value, leading to incorrect grid padding calculations when multiple series with different stroke widths were present.Now, the method checks if
stroke.width
is an array and uses the maximum value from this array for setting grid padding, ensuring that the largest stroke width is properly accommodated.Changes include:
stroke.width
is an array.Math.max(...)
to find the maximum stroke width when necessary.gridPad.top
andgridPad.bottom
.Fixes #4216
Type of change
Checklist: