Bugfixes in Desugarer and propagation of primes #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shonfeder
approved these changes
Jan 25, 2021
tla-pp/src/main/scala/at/forsyte/apalache/tla/pp/Desugarer.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Shon Feder <shon@informal.systems>
shonfeder
pushed a commit
to shonfeder/apalache
that referenced
this pull request
Jan 28, 2021
Co-authored-by: Shon Feder <shon@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues that were found in the last days:
UNCHANGED, see [FEATURE] Desugarer should not throw IllegalArgumentException #471 and [BUG] java.lang.UnsupportedOperationException: empty.reduceLeft #475All these bugs needs modification of
Desugarer. So the bugfixes are all packed in one PR. Additionally, the fixes worked but provoked bugs at later transformations. Hence, this PR also include thePrimePropagationthat propagates primes inside expressions in the general case (temporal operators are not covered though).