-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BYOC][NNAPI]: Add testing package to ci_cpu image #8088
Conversation
This commit adds Android SDK to the ci_cpu image for supporting tests of Android NNAPI BYOC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @melsonlai, thanks for the PR.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi all, i added some updates on #7995 to let you know where we are. given the complexity there, i'd prefer if we could keep this PR out of it and then we can update again after that. The CUDA issues encountered on 18.04 are making this container update more challenging than normal. |
Accordingly, we will put this PR on hold for now, and @areusch will merge it when the issues of updating container images are resolved. |
@melsonlai @comaniac #7995 has landed, since the CI did not fail before, i'm unsure whether we should retest before merging? |
oh sorry, i was just sorting through PRs now and not reading very well. do we now want to move forward with this PR and rebuild containers again? |
Sure we could do that. Please merge this PR when you are going to rebuild the container. |
Rebuilding containers this week. Thanks @melsonlai @areusch @comaniac @leandron |
Hi, had the |
Still working on it :( We've hit lots of incompatible versions and typos in install scripts. See #8177 for details |
This commit adds Android SDK to the ci_cpu image for supporting tests of Android NNAPI BYOC.
This commit adds Android SDK to the ci_cpu image for supporting tests of Android NNAPI BYOC.
This commit adds Android SDK to the ci_cpu image for supporting tests of Android NNAPI BYOC.
See also:
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.