chore: Removing DASHBOARD_CROSS_FILTERS flag and all that comes with it. #31794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
added
the
risk:breaking-change
dosubot
bot
added
the
dashboard:cross-filters
![korbit-ai[bot]](/~https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Cross Filters Default Behavior Changed ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts | ✅ |
| superset-frontend/src/dashboard/util/crossFilters.ts | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/utils.ts | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Horizontal.tsx | ✅ |
| superset-frontend/src/dataMask/reducer.ts | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx | ✅ |
| superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx | ✅ |
| superset-frontend/src/dashboard/components/Dashboard.jsx | ✅ |
| superset-frontend/src/dashboard/actions/hydrate.js | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx | ✅ |
| superset-frontend/src/components/Chart/ChartRenderer.jsx | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/selectors.ts | ✅ |
| superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx | ✅ |
| superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx | ✅ |
| superset-frontend/src/dashboard/actions/dashboardState.js | ✅ |
| superset/config.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
rusackas
force-pushed
the
removing-DASHBOARD_CROSS_FILTERS-flag
branch
from
9b50bf9 to
dbf8a3c
Compare
rusackas
requested review from
michael-s-molina,
mistercrunch,
justinpark,
sadpandajoe and
kgabryje
sadpandajoe
reviewed
Jan 13, 2025
| @@ -475,8 +472,7 @@ const DashboardBuilder = () => { | |||
| ELEMENT_ON_SCREEN_OPTIONS, | |||
| ); | |||
|
|
|||
| const showFilterBar = | |||
| (crossFiltersEnabled || nativeFiltersEnabled) && !editMode; | |||
There was a problem hiding this comment.
was nativeFiltersEnabled already cleaned up?
There was a problem hiding this comment.
Not sure, actually, but it's part of an OR statement, so with crossFiltersEnabled always being true, it doesn't actually matter, so the whole parenthetical will be true, and then showFilterBar can be replaced by !editMode
sadpandajoe
reviewed
Jan 13, 2025
| @@ -104,44 +104,14 @@ test('Dropdown trigger does not render without dashboard edit permissions', asyn | |||
| expect(screen.queryByRole('img', { name: 'gear' })).not.toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| test('Dropdown trigger renders with FF DASHBOARD_CROSS_FILTERS on', async () => { | |||
There was a problem hiding this comment.
Did you want to update this test as just "Dropdown trigger renders"?
There was a problem hiding this comment.
The dropdown trigger is clicked in other tests so I wasn't worried about keeping it as a separate one. Those other tests would fail if it didn't render.
| @@ -45,6 +45,12 @@ describe('nativeFilterGate', () => { | |||
| }); | |||
|
|
|||
| it('should return false for native filter chart with cross filter support', () => { | |||
| isFeatureEnabledMock.mockImplementation(feature => { | |||
| if (feature === FeatureFlag.DASHBOARD_CROSS_FILTERS) return false; | |||
There was a problem hiding this comment.
I believe FeatureFlag.DASHBOARD_CROSS_FILTERS will not exist anymore given that we are removing the feature flag. We need to remove all references of it.
There was a problem hiding this comment.
Yeah, I did, and then I tried using Cursor to get tests to pass, and it brought it right back! Ugh.
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Approved 5.0 change. The feature is now ready for prime time!
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION