chore: Rename SET_ACTIVE_TABS action, add a new action #26147
Merged
+41
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| it('SET_ACTIVE_TABS', () => { | ||
| expect( | ||
| dashboardStateReducer({ activeTabs: [] }, setActiveTabs(['tab1'])), |
There was a problem hiding this comment.
Should this be setActiveTab instead of setActiveTabs?
There was a problem hiding this comment.
No, it's a new test for the new action
Antonio-RiveroMartnez
approved these changes
Nov 30, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26147 +/- ##
=======================================
Coverage 69.09% 69.09%
=======================================
Files 1941 1941
Lines 75891 75894 +3
Branches 8450 8450
=======================================
+ Hits 52436 52439 +3
Misses 21280 21280
Partials 2175 2175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michael-s-molina
added
the
v3.1
michael-s-molina
pushed a commit
that referenced
this pull request
Dec 4, 2023
(cherry picked from commit d00c17d)
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
(cherry picked from commit d00c17d)
mistercrunch
added
🍒 3.1.0
🍒 3.1.1
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Previously
SET_ACTIVE_TABSwere in fact changing only 1 active tab in an array of tabs. I renamed it toSET_ACTIVE_TABand created a newSET_ACTIVE_TABSaction which allows us to programatically set active tabs state in the dashboard.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
No functional changes, added unit test for the new action.
ADDITIONAL INFORMATION