Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-chart-pivot-table): Add more descriptive tooltips for sorting [ID-29] #17634

Merged
merged 3 commits into from
Dec 2, 2021
Merged

chore(plugin-chart-pivot-table): Add more descriptive tooltips for sorting [ID-29] #17634

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e15d25c
chore(plugin-chart-pivot-table): Add more descriptive tooltips for so…
kgabryje Dec 2, 2021
75adb00
Update superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/…
kgabryje Dec 2, 2021
f7d1b81
Update superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/…
kgabryje Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions ...rt-pivot-table/src/plugin/controlPanel.ts → ...t-pivot-table/src/plugin/controlPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import {
QueryFormMetric,
smartDateFormatter,
Expand Down Expand Up @@ -225,7 +226,7 @@ const config: ControlPanelConfig = {
name: 'rowOrder',
config: {
type: 'SelectControl',
label: t('Rows sort by'),
label: t('Sort rows by'),
default: 'key_a_to_z',
choices: [
// [value, label]
Expand All @@ -235,7 +236,16 @@ const config: ControlPanelConfig = {
['value_z_to_a', t('value descending')],
],
renderTrigger: true,
description: t('Order of rows'),
description: (
<React.Fragment>
<div>{t('Change order of rows.')}</div>
<div>{t('Available sorting modes:')}</div>
<ul>
<li>{t('By key: use rows names as sorting key')}</li>
<li>{t('By value: use metrics values as sorting key')}</li>
kgabryje marked this conversation as resolved.
Show resolved Hide resolved
</ul>
</React.Fragment>
),
},
},
],
Expand All @@ -244,7 +254,7 @@ const config: ControlPanelConfig = {
name: 'colOrder',
config: {
type: 'SelectControl',
label: t('Cols sort by'),
label: t('Sort columns by'),
default: 'key_a_to_z',
choices: [
// [value, label]
Expand All @@ -254,7 +264,16 @@ const config: ControlPanelConfig = {
['value_z_to_a', t('value descending')],
],
renderTrigger: true,
description: t('Order of columns'),
description: (
<React.Fragment>
<div>{t('Change order of columns.')}</div>
<div>{t('Available sorting modes:')}</div>
<ul>
<li>{t('By key: use columns names as sorting key')}</li>
<li>{t('By value: use metrics values as sorting key')}</li>
kgabryje marked this conversation as resolved.
Show resolved Hide resolved
</ul>
</React.Fragment>
),
},
},
],
Expand All @@ -280,7 +299,7 @@ const config: ControlPanelConfig = {
name: 'colSubtotalPosition',
config: {
type: 'SelectControl',
label: t('Cols subtotal position'),
label: t('Columns subtotal position'),
default: false,
choices: [
// [value, label]
Expand Down