Support extract timestamp from patterned datetime string in LAL. #11489
Conversation
wu-sheng
added
backend
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…mp-in-lal' into feature/extract-patterned-timstamp-in-lal
|
|
||
| # This file is used to show how to write configuration files and can be used to test. | ||
|
|
||
| setup: |
There was a problem hiding this comment.
Your new e2e seems not to be added to the GHA control file.
There was a problem hiding this comment.
So, all the tests are not running.
There was a problem hiding this comment.
Sorry, I forgot it. I will update it.
There was a problem hiding this comment.
I am a little confused. Where do you set this log test with the new timestamp style? I can't find it.
There was a problem hiding this comment.
And I can see this has been tested through UT. I don't think this is so complex that we have to test it through e2e again, right? @kezhenxu94
There was a problem hiding this comment.
If so, and if you want to keep the e2e, you could add this LAL and verification into simple case, it should work too, right?
There was a problem hiding this comment.
If so, and if you want to keep the e2e, you could add this LAL and verification into
simplecase, it should work too, right?
I add another UT in LogTestQueryTest, it can check the extract result.
There was a problem hiding this comment.
Could you please show me how to ref the code in comment? I can not find it, I have to pin a picture every time I want show you the code.
There was a problem hiding this comment.
You could get this from the Github pages.
And the permlink is locked for this commit.
There was a problem hiding this comment.
You could get this from the Github pages.
And the permlink is locked for this commit.
Thanks, I will try this way next.
|
Is this change somehow breaking zabbix case? It fails twice. |
I am not sure, I will check it in my local. |
zabbix release latest agent image 21 hours ago, it can not start up in my local, maybe this broken the test case?
|
I change zabbix tag to alpine-latest, the case passed. |
Can you also push the changes in this PR? |
Ok, I will. |
extract timestamp from patterned datetime string in LAL
If this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes Support extract timestamp with specified pattern in LAL. #11484.
Update the
CHANGESlog.