Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connecting to Firebird via jdbcUrl containing the absolute path to fdb #34335

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

linghengqian
Copy link
Member

For #29052.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@linghengqian linghengqian marked this pull request as ready for review January 13, 2025 09:17
Comment on lines +59 to +60
assertDoesNotThrow(() -> parser.parse("jdbc:firebirdsql:xxxxxxxx", null, null));
assertThrows(SQLNonTransientConnectionException.class, () -> parser.parse("jdbc:firebirdsql://localhost:c:/data/db/test.fdb", null, null));
Copy link
Member Author

@linghengqian linghengqian Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@TedCraft TedCraft Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the manual (/~https://github.com/FirebirdSQL/jaybird-manual/blob/master/src/docs/asciidoc/chapters/connection/connection.adoc#pure_java-type) the jdbcUrl format jdbc:firebirdsql:xxxxxxxxxxxx kinda makes sense, since it uses the legacy url format used in firebird. In this case, we just specify the database alias (or path) and the host and port are used by default (localhost:3050). But even though this url type is supported, according to the same manual, it is recommended to use the new url format.

Copy link
Member Author

@linghengqian linghengqian Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • My understanding is that I should respect the behavior of the Firebird JDBC Driver's classes.

  • There seems to be only the LGPL LICENSE for the Firebird JDBC Driver, so I would assume that everyone who uses both shardingsphere and the Firebird JDBC Driver would be affected by the LGPL. Maven's optional property is enough to comply with the ASF's requirements when distributing. I think there is no problem with PR at the moment.

@linghengqian linghengqian added this to the 5.5.2 milestone Jan 13, 2025
@strongduanmu strongduanmu merged commit 5a4cba0 into apache:master Jan 14, 2025
147 checks passed
@linghengqian linghengqian deleted the fix-firebird branch January 14, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants