Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ShardingTableBroadcastRoutingEngine and SingleTableSQLRouter logic for PostgreSQL schema #17155

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

strongduanmu
Copy link
Member

Ref #14004.

Changes proposed in this pull request:

  • optimize ShardingTableBroadcastRoutingEngine logic for PostgreSQL schema
  • optimize SingleTableSQLRouter logic for PostgreSQL schema
  • modify unit test

@codecov-commenter
Copy link

Codecov Report

Merging #17155 (5e252d5) into master (6533e51) will increase coverage by 0.11%.
The diff coverage is 39.13%.

@@             Coverage Diff              @@
##             master   #17155      +/-   ##
============================================
+ Coverage     60.26%   60.38%   +0.11%     
- Complexity     2114     2115       +1     
============================================
  Files          3490     3492       +2     
  Lines         52192    52213      +21     
  Branches       8883     8889       +6     
============================================
+ Hits          31456    31530      +74     
+ Misses        18100    18038      -62     
- Partials       2636     2645       +9     
Impacted Files Coverage Δ
...resher/type/DropIndexStatementSchemaRefresher.java 13.63% <0.00%> (+3.95%) ⬆️
...sphere/singletable/route/SingleTableSQLRouter.java 62.06% <50.00%> (ø)
.../route/engine/type/ShardingRouteEngineFactory.java 68.67% <100.00%> (+0.43%) ⬆️
...broadcast/ShardingTableBroadcastRoutingEngine.java 68.00% <100.00%> (+0.65%) ⬆️
.../infra/metadata/schema/util/IndexMetaDataUtil.java 80.00% <100.00%> (+2.22%) ⬆️
...est/column/value/impl/MySQLUnsignedIntHandler.java 66.66% <0.00%> (-33.34%) ⬇️
...column/value/impl/MySQLUnsignedTinyintHandler.java 66.66% <0.00%> (-33.34%) ⬇️
...olumn/value/impl/MySQLUnsignedSmallintHandler.java 66.66% <0.00%> (-33.34%) ⬇️
...lumn/value/impl/MySQLUnsignedMediumintHandler.java 66.66% <0.00%> (-33.34%) ⬇️
.../column/value/impl/MySQLUnsignedBigintHandler.java 71.42% <0.00%> (-28.58%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6533e51...5e252d5. Read the comment docs.

@zhaojinchao95 zhaojinchao95 merged commit b01274c into apache:master Apr 28, 2022
@strongduanmu strongduanmu deleted the sharding-engine-optimize branch April 28, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants