Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust schemaName to databaseName #16930

Merged
merged 8 commits into from
Apr 19, 2022
Merged

Adjust schemaName to databaseName #16930

merged 8 commits into from
Apr 19, 2022

Conversation

zhaojinchao95
Copy link
Contributor

For #14004

@zhaojinchao95 zhaojinchao95 added this to the 5.1.2 milestone Apr 19, 2022
@zhaojinchao95 zhaojinchao95 marked this pull request as draft April 19, 2022 12:01
@zhaojinchao95 zhaojinchao95 marked this pull request as ready for review April 19, 2022 12:15
@zhaojinchao95 zhaojinchao95 marked this pull request as draft April 19, 2022 12:20
@codecov-commenter
Copy link

Codecov Report

Merging #16930 (0bb8deb) into master (21b6b78) will increase coverage by 0.03%.
The diff coverage is 95.57%.

@@             Coverage Diff              @@
##             master   #16930      +/-   ##
============================================
+ Coverage     60.19%   60.23%   +0.03%     
  Complexity     2128     2128              
============================================
  Files          3441     3439       -2     
  Lines         51739    51700      -39     
  Branches       8845     8844       -1     
============================================
- Hits          31146    31139       -7     
+ Misses        17971    17938      -33     
- Partials       2622     2623       +1     
Impacted Files Coverage Δ
...ateShardingBroadcastTableRuleStatementUpdater.java 0.00% <0.00%> (ø)
...tion/resource/RequiredResourceMissedException.java 0.00% <0.00%> (ø)
...le/DropDefaultSingleTableRuleStatementUpdater.java 75.00% <66.66%> (ø)
...er/update/DropShadowAlgorithmStatementUpdater.java 65.62% <71.42%> (ø)
.../CreateDefaultSingleTableRuleStatementUpdater.java 73.68% <80.00%> (ø)
...terDatabaseDiscoveryHeartbeatStatementUpdater.java 70.83% <85.71%> (ø)
...te/AlterDatabaseDiscoveryTypeStatementUpdater.java 87.09% <85.71%> (ø)
.../AlterDefaultShardingStrategyStatementUpdater.java 90.56% <85.71%> (ø)
...lterShardingBindingTableRulesStatementUpdater.java 45.94% <85.71%> (ø)
...reateShardingBindingTableRuleStatementUpdater.java 52.94% <85.71%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b6b78...0bb8deb. Read the comment docs.

@zhaojinchao95 zhaojinchao95 marked this pull request as ready for review April 19, 2022 23:35
@strongduanmu strongduanmu merged commit 9c8446d into apache:master Apr 19, 2022
@zhaojinchao95 zhaojinchao95 deleted the schem-to-databse branch April 20, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants