Improve DataSourcePreparer unit test (#21044)

apache · Sep 18, 2022 · 023ba31 · 023ba31
1 parent 66923e4
commit 023ba31
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 112 deletions.
diff --git a/...he/shardingsphere/data/pipeline/mysql/prepare/datasource/MySQLDataSourcePreparerTest.java b/...he/shardingsphere/data/pipeline/mysql/prepare/datasource/MySQLDataSourcePreparerTest.java
diff --git a/.../shardingsphere/data/pipeline/core/prepare/datasource/AbstractDataSourcePreparerTest.java b/.../shardingsphere/data/pipeline/core/prepare/datasource/AbstractDataSourcePreparerTest.java
@@ -17,15 +17,23 @@
 
 package org.apache.shardingsphere.data.pipeline.core.prepare.datasource;
 
+import org.apache.shardingsphere.data.pipeline.api.datasource.PipelineDataSourceManager;
+import org.apache.shardingsphere.data.pipeline.api.datasource.config.PipelineDataSourceConfiguration;
 import org.junit.Test;
 
+import java.sql.Connection;
+import java.sql.SQLException;
+import java.sql.Statement;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.regex.Pattern;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
 
 public final class AbstractDataSourcePreparerTest {
 
@@ -38,6 +46,24 @@ public void prepareTargetTables(final PrepareTargetTablesParameter parameter) {
         }
     };
 
+    @Test
+    public void assertGetCachedDataSource() {
+        PipelineDataSourceConfiguration dataSourceConfig = mock(PipelineDataSourceConfiguration.class);
+        PipelineDataSourceManager dataSourceManager = mock(PipelineDataSourceManager.class);
+        preparer.getCachedDataSource(dataSourceConfig, dataSourceManager);
+        verify(dataSourceManager).getDataSource(dataSourceConfig);
+    }
+
+    @Test
+    public void assertExecuteTargetTableSQL() throws SQLException {
+        Statement statement = mock(Statement.class);
+        Connection targetConnection = mock(Connection.class);
+        when(targetConnection.createStatement()).thenReturn(statement);
+        String sql = "CREATE TABLE t (id int)";
+        preparer.executeTargetTableSQL(targetConnection, sql);
+        verify(statement).execute(sql);
+    }
+
     @Test
     public void assertAddIfNotExistsForCreateTableSQL() {
         Collection<String> createTableSQLs = Arrays.asList("CREATE TABLE IF NOT EXISTS t (id int)", "CREATE TABLE t (id int)",