Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14271 - dynamic property support in Kafka3ConnectionService #9747

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

greyp9
Copy link
Contributor

@greyp9 greyp9 commented Feb 25, 2025

Since the component validation evaluates the service configuration as a whole, the connection service may be supplied with both publish and consume dynamic properties.

The instantiation of a "KafkaProducerService" should filter the effective dynamic properties to those supported by a "KafkaProducer". Similarly, a "KafkaConsumerService" only applies the dynamic properties supported by a Kafka "Consumer". This logic should be governed by the existing NiFi ":kafka-shared" class "KafkaPropertyProvider", and may be verified at runtime via inspection of the ProducerConfig / ConsumerConfig properties written to the NiFi log at connection initiation.

Summary

NIFI-14271

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant