NIFI-14285 ConsumeKinesisStream Record Wrapper #9738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszseweryn
force-pushed
the
NIFI-14285
branch
from
1e01ced to
87d3bf9
Compare
exceptionfactory
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Thanks for introducing this new property support @dariuszseweryn. The general approach looks good. I noted a few implementation detail recommendations.
...processors/src/main/java/org/apache/nifi/processors/aws/kinesis/property/OutputStrategy.java
Outdated
Show resolved
Hide resolved
...processors/src/main/java/org/apache/nifi/processors/aws/kinesis/property/OutputStrategy.java
Outdated
Show resolved
Hide resolved
...essors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/ConsumeKinesisStream.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/nifi/processors/aws/kinesis/stream/record/converter/RecordConverter.java
Outdated
Show resolved
Hide resolved
.../org/apache/nifi/processors/aws/kinesis/stream/record/converter/RecordConverterIdentity.java
Outdated
Show resolved
Hide resolved
...rs/src/test/java/org/apache/nifi/processors/aws/kinesis/stream/TestConsumeKinesisStream.java
Outdated
Show resolved
Hide resolved
...a/org/apache/nifi/processors/aws/kinesis/stream/record/converter/RecordConverterWrapper.java
Outdated
Show resolved
Hide resolved
...a/org/apache/nifi/processors/aws/kinesis/stream/record/converter/RecordConverterWrapper.java
Outdated
Show resolved
Hide resolved
| metadata.put(SEQUENCE_NUMBER, consumerRecord.sequenceNumber()); | ||
| metadata.put(PARTITION_KEY, consumerRecord.partitionKey()); | ||
| final Instant approxArrivalTimestamp = consumerRecord.approximateArrivalTimestamp(); | ||
| metadata.put(APPROX_ARRIVAL_TIMESTAMP, approxArrivalTimestamp != null ? approxArrivalTimestamp.toEpochMilli() : null); |
There was a problem hiding this comment.
Recommend reversing the ternary conditional as follows:
Suggested change
| metadata.put(APPROX_ARRIVAL_TIMESTAMP, approxArrivalTimestamp != null ? approxArrivalTimestamp.toEpochMilli() : null); | |
| metadata.put(APPROX_ARRIVAL_TIMESTAMP, approxArrivalTimestamp == null ? null : approxArrivalTimestamp.toEpochMilli()); |
There was a problem hiding this comment.
NP, is there such convention explained? Always thought that the null case is less interesting and therefore it can come last
...a/org/apache/nifi/processors/aws/kinesis/stream/record/converter/RecordConverterWrapper.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14285
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-14285NIFI-14285Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation