Create new output channel for every LspIO #8000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhorvath
added
LSP
jhorvath
force-pushed
the
vscode-named-output
branch
2 times, most recently
from
d0d98d1 to
430bab6
Compare
sdedic
reviewed
Nov 29, 2024
...a.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/AbstractLspInputOutputProvider.java
Outdated
Show resolved
Hide resolved
jhorvath
force-pushed
the
vscode-named-output
branch
from
430bab6 to
ba69242
Compare
jhorvath
force-pushed
the
vscode-named-output
branch
from
ba69242 to
73902be
Compare
sdedic
reviewed
Dec 10, 2024
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/Server.java
Show resolved
Hide resolved
jhorvath
force-pushed
the
vscode-named-output
branch
from
73902be to
a37f3b8
Compare
jhorvath
force-pushed
the
vscode-named-output
branch
from
a37f3b8 to
c0b7c75
Compare
sdedic
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All outputs were written to the Apache Netbeans Language Server channel. This meant that even build logs were written there and mixed together with netbeans log messages. Now a new channel will be created for new LspIO.