Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.7] Cherry pick Increase staggered build timeout (#18568) #18585

Merged
merged 2 commits into from
Jul 2, 2020
Merged

[v1.7] Cherry pick Increase staggered build timeout (#18568) #18585

merged 2 commits into from
Jul 2, 2020

Conversation

josephevans
Copy link
Contributor

  • Increase staggered build timeout to 180 min, since sanity build has 180 min timeout.

  • Decrease timeout so everyone is happy.

Co-authored-by: Joe Evans joeev@amazon.com

@josephevans
Increase staggered build timeout to 180 min (apache#18568)
5fa556d 
* Increase staggered build timeout to 180 min, since sanity build has 180 min timeout.

* Decrease timeout so everyone is happy.

Co-authored-by: Joe Evans <joeev@amazon.com>
@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, miscellaneous, centos-cpu, clang, edge, centos-gpu, unix-cpu, windows-cpu, unix-gpu, website, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@josephevans
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@ciyongch
Copy link
Contributor

Hi @josephevans , please help to re-trigger the unix-gpu job as it's stuck.
The modification increases the full time from 30min to 60 min, while decrease the sanity time from 180min to 60min, seems not align to the description?

@josephevans
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@josephevans
Copy link
Contributor Author

Hi @josephevans , please help to re-trigger the unix-gpu job as it's stuck.
The modification increases the full time from 30min to 60 min, while decrease the sanity time from 180min to 60min, seems not align to the description?

Hi @ciyongch, we actually increased the overall "full" job which first triggers sanity build, then if it passes we run the rest of the jobs. But since it doesn't make sense to have a longer timeout for sanity build than the "full" build, we made them the same. If the sanity build timed out, the full build would have already timed out of the timeout is longer.

@ciyongch
Copy link
Contributor

Thanks for the update @josephevans . Ping @leezu @marcoabreu @aaronmarkham to have a review and help merge. Thanks!

@ciyongch
Copy link
Contributor

ciyongch commented Jul 2, 2020

Hi @leeze @ChaiBapchya @marcoabreu @aaronmarkham , can you help to take a review and merged. The corresponding one #18568 to v1.x branch is already merged.

ciyongch
ciyongch approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@ciyongch ciyongch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@TaoLv @pengzhao-intel please help to merge.

@TaoLv TaoLv merged commit c2ddd81 into apache:v1.7.x Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ciyongch ciyongch ciyongch approved these changes

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josephevans @mxnet-bot @ciyongch @ChaiBapchya @TaoLv