-
Notifications
You must be signed in to change notification settings - Fork 6.8k
ONNX import/export: Upsampling #15994
base: master
Are you sure you want to change the base?
Conversation
@mxnet-label-bot add [ONNX, pr-awaiting-review] |
if it depends on the above PR, which is not merged, then how are the tests passing? |
Any update on this PR? |
Any development? Also facing an Upsampling issue trying to import: |
Thanks for working on this, I am interested in exporting a model to ONNX with Upsampling (nearest). Currently it complains It would really great if this PR can move on and get merged. |
I'd like to reiterate what @oeway said by first thanking you for working on this. Also, please note there is no way to redesign a model around this problem as alternatives such as repeat and deconvolution also cause the export to fail. This problem has been lingering for quite some time. Maybe @szha can assign this to someone. |
@jeremiedb @oeway @oriori I have asked( offline) @vandanavk to rebase the PR. Once she does, I will review/merge the PR. |
Pinging @vandanavk. BTW, since master branch is for 2.0 development and Upsampling op will be reorganized elsewhere, based on the change, I recommend switching the target branch to 1.x instead. cc @sandeep-krishnamurthy on ONNX op coverage |
|
||
@mx_op.register("UpSampling") | ||
def convert_upsample(node, **kwargs): | ||
"""Map MXNet's UpSampling operator attributes to onnx's Upsample operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing the end """ at line 2086?
@vandanavk @anirudhacharya @kreid415 @jeremiedb @oeway Sorry to bother you again, I want to import ONNX model from MXnet, I changed my corresponding file according to Files changed, another error occurred after I changed:
Since I'm new to these, I don't quite understand what the error is. By the way, can Upsample be imported into MXNET so far? Has this been achieved? Thank you and look forward to your reply. |
Description
Support ONNX import/export of Upsampling operator.
Fixes #12851
Depends on #15811
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments