[MXNET-1287] Feat dep #14668

zachgk · 2019-04-10T19:33:53Z

Description

This PR fixes the feature/deprecation warnings and makes them display as part of the Maven run by default. Most of the fixes are related to the change to IndexedSeq[DataDesc]. Contains a part of #13995.

@lanking520 @andrewfayres

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

zachgk · 2019-04-10T19:34:09Z

@mxnet-label-bot add [Scala, Maven, pr-awaiting-review]

lanking520

General question: why we need to import postfixop library?
Please also explain the comments below

All the rest looks fine since covered by the tests.

lanking520 · 2019-04-11T19:11:18Z

scala-package/core/src/main/scala/org/apache/mxnet/io/PrefetchingIter.scala

    }
  }

-  private val _provideLabel: ListMap[String, Shape] = {
+  @deprecated("Please use provideDataDesc instead", "1.3.0")
+  override def provideLabel: ListMap[String, Shape] = {


Why not make it private?

The _provideLabel was a private implementation of the externally accessible provideLabel. I thought there was no point in having both so I combined them and left the public one.

lanking520 · 2019-04-11T19:12:50Z

scala-package/examples/src/main/scala/org/apache/mxnetexamples/neuralstyle/NeuralStyle.scala

@@ -39,7 +39,7 @@ object NeuralStyle {
  private val logger = LoggerFactory.getLogger(classOf[NeuralStyle])

  def preprocessContentImage(path: String, longEdge: Int, ctx: Context): NDArray = {
-    val img = Image(new File(path))
+    val img = Image.fromFile(new File(path))


Why change this?

There was a warning against using Image(). I don't remember what the warning was, though.

zachgk

The import of postfix, along with the rest of scala.language, is to enable various language features that are not default. The postfix operation seemed to mostly be used for CLI execution such as:

"python -m SimpleHTTPServer" !

zachgk · 2019-04-11T20:06:51Z

scala-package/core/src/main/scala/org/apache/mxnet/io/PrefetchingIter.scala

    }
  }

-  private val _provideLabel: ListMap[String, Shape] = {
+  @deprecated("Please use provideDataDesc instead", "1.3.0")
+  override def provideLabel: ListMap[String, Shape] = {


The _provideLabel was a private implementation of the externally accessible provideLabel. I thought there was no point in having both so I combined them and left the public one.

zachgk · 2019-04-11T20:07:42Z

scala-package/examples/src/main/scala/org/apache/mxnetexamples/neuralstyle/NeuralStyle.scala

@@ -39,7 +39,7 @@ object NeuralStyle {
  private val logger = LoggerFactory.getLogger(classOf[NeuralStyle])

  def preprocessContentImage(path: String, longEdge: Int, ctx: Context): NDArray = {
-    val img = Image(new File(path))
+    val img = Image.fromFile(new File(path))


There was a warning against using Image(). I don't remember what the warning was, though.

lanking520 · 2019-04-14T16:23:01Z

Does the Scala GPU failure related to your changes?

* Feature and Deprecation Warnings * Address feature and deprecation Warnings (mostly provideData) * Fix name search

zachgk requested review from nswamy and yzhliu as code owners April 10, 2019 19:33

marcoabreu added Maven pr-awaiting-review PR is waiting for code review Scala labels Apr 10, 2019

zachgk mentioned this pull request Apr 10, 2019

[MXNET-1287] Scala compiler warnings #13995

Closed

12 tasks

zachgk force-pushed the featDep branch from 56bf934 to e87e913 Compare April 11, 2019 18:50

lanking520 suggested changes Apr 11, 2019

View reviewed changes

zachgk commented Apr 11, 2019

View reviewed changes

lanking520 approved these changes Apr 11, 2019

View reviewed changes

zachgk added 2 commits April 11, 2019 17:25

Feature and Deprecation Warnings

0d2fa2c

Address feature and deprecation Warnings (mostly provideData)

d8ea02e

zachgk force-pushed the featDep branch from e87e913 to d8ea02e Compare April 12, 2019 00:27

Fix name search

bdd0d8e

lanking520 merged commit 5b6e25b into apache:master Apr 19, 2019

kedarbellare pushed a commit to kedarbellare/incubator-mxnet that referenced this pull request Apr 20, 2019

[MXNET-1287] Feat dep (apache#14668)

ea01812

* Feature and Deprecation Warnings * Address feature and deprecation Warnings (mostly provideData) * Fix name search

haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019

[MXNET-1287] Feat dep (apache#14668)

fccf044

* Feature and Deprecation Warnings * Address feature and deprecation Warnings (mostly provideData) * Fix name search

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MXNET-1287] Feat dep #14668

[MXNET-1287] Feat dep #14668

zachgk commented Apr 10, 2019

zachgk commented Apr 10, 2019

lanking520 left a comment

lanking520 Apr 11, 2019

zachgk Apr 11, 2019

lanking520 Apr 11, 2019

zachgk Apr 11, 2019

zachgk left a comment

zachgk Apr 11, 2019

zachgk Apr 11, 2019

lanking520 commented Apr 14, 2019

[MXNET-1287] Feat dep #14668

[MXNET-1287] Feat dep #14668

Conversation

zachgk commented Apr 10, 2019

Description

Checklist

Essentials

zachgk commented Apr 10, 2019

lanking520 left a comment

Choose a reason for hiding this comment

lanking520 Apr 11, 2019

Choose a reason for hiding this comment

zachgk Apr 11, 2019

Choose a reason for hiding this comment

lanking520 Apr 11, 2019

Choose a reason for hiding this comment

zachgk Apr 11, 2019

Choose a reason for hiding this comment

zachgk left a comment

Choose a reason for hiding this comment

zachgk Apr 11, 2019

Choose a reason for hiding this comment

zachgk Apr 11, 2019

Choose a reason for hiding this comment

lanking520 commented Apr 14, 2019