This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @ptrendx |
Thanks for your contributions @haojin2. Can you also look into the CI failures ? @mxnet-label-bot Add [Operator, Backend] |
haojin2
force-pushed
the
safe_norm
branch
2 times, most recently
from
April 9, 2019 20:32
15f00ef
to
884b7a3
Compare
haojin2
force-pushed
the
safe_norm
branch
12 times, most recently
from
April 11, 2019 21:02
bb297b8
to
04cda68
Compare
kedarbellare
pushed a commit
to kedarbellare/incubator-mxnet
that referenced
this pull request
Apr 20, 2019
* use safe aggregation for norm * safe norm with DataType, AccuType and OutType * new test for backward * change back to MSHADOW_TYPE_SWITCH * remove dead debug outputs * Allow integer types
8 tasks
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* use safe aggregation for norm * safe norm with DataType, AccuType and OutType * new test for backward * change back to MSHADOW_TYPE_SWITCH * remove dead debug outputs * Allow integer types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resurrection of #14240 to solve #14126. With an extra argument of norm for specification of output data type.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@szha
Unit test passed 10000 times on GPU: