This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[clojure][image] add draw-bounding-box interop #14533
Merged
gigasquid
merged 2 commits into
apache:master
from
Chouffe:chouffe/clojure-bounding-box
Mar 29, 2019
Merged
[clojure][image] add draw-bounding-box interop #14533
gigasquid
merged 2 commits into
apache:master
from
Chouffe:chouffe/clojure-bounding-box
Mar 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot add [Clojure, pr-awaiting-review] |
Thanks for this contribution. Will take a closer look in a bit 😸 |
gigasquid
approved these changes
Mar 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! thanks!
@@ -199,3 +200,68 @@ | |||
[input] | |||
(util/validate! ::to-image-ndarray input "Invalid input array") | |||
(Image/toImage input)) | |||
|
|||
(s/def ::buffered-image #(instance? BufferedImage %)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice specs 😍
`stroke`: positive integer - thickness of the bounding box | ||
`transparency`: float in (0.0, 1.0) - Transparency of the bounding box | ||
returns: Modified `buffered-image` | ||
Ex: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the examples in the docstring
4 tasks
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* [clojure][image] add draw-bounding-box interop * [clojure][image] add more specs and type conversion
ZhennanQin
pushed a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
* [clojure][image] add draw-bounding-box interop * [clojure][image] add more specs and type conversion
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* [clojure][image] add draw-bounding-box interop * [clojure][image] add more specs and type conversion
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* [clojure][image] add draw-bounding-box interop * [clojure][image] add more specs and type conversion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How it was tested
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.