Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix script retrieval #14519

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Fix script retrieval #14519

merged 2 commits into from
Mar 27, 2019

Conversation

vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Mar 25, 2019 •
edited
Loading

Description

Removing reference to CI scripts in documentation

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Change to do generic installation

Comments

@vandanavk vandanavk requested a review from szha as a code owner March 25, 2019 23:32
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot add [Java, Doc, pr-awaiting-review]

@marcoabreu marcoabreu added Doc Java Label to identify Java API component pr-awaiting-review PR is waiting for code review labels Mar 25, 2019
piyushghai
piyushghai approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @vandanavk !
LGTM

wkcn
wkcn approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@vandanavk
Copy link
Contributor Author

@mxnet-label-bot update [Java, Doc, pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Mar 25, 2019
@marcoabreu
Copy link
Contributor

FYI, This file is not intended for enduser usage and I'd not recommend linking it in any documentation.

@vandanavk
Copy link
Contributor Author

@marcoabreu Changed the command to use generic installation. Can these instructions be used now that CI scripts are not referenced?

@lanking520 for review

@wkcn wkcn merged commit c4cd49c into apache:master Mar 27, 2019
@wkcn
Copy link
Member

wkcn commented Mar 27, 2019 •
edited
Loading

The PR has been merged. Thank you!

vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@vandanavk @vdantu
Fix script retrieval (apache#14519)
4c9286a 
* Correct script wget. Without this change, wget was retrieving html.

* Dont use CI scripts
ZhennanQin pushed a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
@vandanavk @ZhennanQin
Fix script retrieval (apache#14519)
13c60f2 
* Correct script wget. Without this change, wget was retrieving html.

* Dont use CI scripts
nswamy pushed a commit that referenced this pull request Apr 5, 2019
@vandanavk @nswamy
Fix script retrieval (#14519)
a350661 
* Correct script wget. Without this change, wget was retrieving html.

* Dont use CI scripts
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@vandanavk
Fix script retrieval (apache#14519)
4b333d8 
* Correct script wget. Without this change, wget was retrieving html.

* Dont use CI scripts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoabreu marcoabreu marcoabreu approved these changes

@lanking520 lanking520 lanking520 approved these changes

@piyushghai piyushghai piyushghai approved these changes

@wkcn wkcn wkcn approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Doc Java Label to identify Java API component pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vandanavk @marcoabreu @wkcn @piyushghai @lanking520