This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkcn
changed the title
fix SoftmaxOutput resource bug
[WIP]fix SoftmaxOutput resource bug
Mar 2, 2019
wkcn
changed the title
[WIP]fix SoftmaxOutput resource bug
fix SoftmaxOutput resource bug
Mar 2, 2019
Thanks for the quick fix :) |
@pengzhao-intel I will add the test case for SoftmaxOutput. Thanks! Edit: I have written the test case : ) |
wkcn
changed the title
fix SoftmaxOutput resource bug
[WIP]fix SoftmaxOutput resource bug
Mar 2, 2019
wkcn
added
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-review
PR is waiting for code review
labels
Mar 2, 2019
wkcn
changed the title
[WIP]fix SoftmaxOutput resource bug
fix SoftmaxOutput resource bug
Mar 2, 2019
wkcn
added
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
labels
Mar 2, 2019
szha
approved these changes
Mar 4, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* fix SoftmaxOutput resource * remove BackwardResource since SoftmaxOutput is not a legacy op * add test_SoftmaxOutput_normalization * igore_label=-1 when use_ignore=False * retrigger CI * add multi_output test for SoftmaxOutput * rename test_SoftmaxOutput_normalization to test_softmax_output_normalization * retrigger CI * retrigger CI * fix test bug
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* fix SoftmaxOutput resource * remove BackwardResource since SoftmaxOutput is not a legacy op * add test_SoftmaxOutput_normalization * igore_label=-1 when use_ignore=False * retrigger CI * add multi_output test for SoftmaxOutput * rename test_SoftmaxOutput_normalization to test_softmax_output_normalization * retrigger CI * retrigger CI * fix test bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #14301
It seems that
BackwardResource
insrc/operator/softmax_output-inl.h
is not used in SoftmaxOutput since it is not a legacy operator.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
BackwardResource
insrc/operator/softmax_output-inl.h
ResourceRequest
insrc/operator/softmax_output.cc
Comments
SoftmaxOutput
is not a legacy operator, which is registered byNNVM_REGISTER_OP
rather thanMXNET_REGISTER_OP_PROPERTY
, soBackwardResource
is not used for it.Meanwhile, I check all operators. Only
SoftmaxOutput
has the problem.