This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix SliceLikeBackward #14209
Merged
Fix SliceLikeBackward #14209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 28, 2019
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 28, 2019
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 28, 2019
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Mar 4, 2019
This was referenced Mar 7, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
slice_likeoperator, where, if the first input is constant, the backward pass of this operator would not fill the gradient to the second input with zeros, instead passing random memory contents.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
slice_likeis used in anchor generator (/~https://github.com/dmlc/gluon-cv/blob/master/gluoncv/model_zoo/ssd/anchor.py#L70):where the work around was to multiply the second input by 0 (effectively zeroing the gradient). With this PR, this work around is not needed anymore (and it is also not fully safe - NaNs and Infs in the memory returned from SliceLikeBackward would produce NaNs when multiplied by 0 and so would still break the training). @zhreshold FYI
@eric-haibin-lin