-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.4.x] Update MKL-DNN to fix the OSX build issue #14141
Conversation
Weird CI failures.. :( |
@TaoLv Thanks for your contribution! Could you please look into CI failures? @mxnet-label-bot add [pr-awaiting-testing, MKLDNN, Build] |
Restarted :), @marcoabreu could you also grant CI access to @TaoLv so he will be able to retrigger the test next time |
@TaoLv
Not sure if this is related to your changes in this PR. |
Retrigger the test again, not sure if there is an issue with Cent OS. But I do saw multiple failure in the Cent OS testing |
Thank you for your attention @lanking520, @piyushghai. The test_stn issue was fixed on master branch several day ago: #14063. But the fix is not ported to v1.4.x branch. |
@TaoLv I cherry-picked the fix. I will merge this PR if there's no other issue. |
Errors: |
None looks related to mkldnn. |
@TaoLv Contribute back to master? |
MKL-DNN 0.18 is coming soon: /~https://github.com/intel/mkl-dnn/releases/tag/v0.18-rc. We plan to update master directly to 0.18 release. Internal validation is WIP. |
@TaoLv master pip build for mac mkl is still failing, so I'd recommend patching master too, ASAP. |
@TaoLv The OSX build from source is not working still. It's broken. I tried a simple command : |
Update --> Ignore my previous comment. I resolved the issue thanks to @lanking520 |
* update mkldnn to 0.17.x * update mkldnn to 0.17.4 * empty commit
…ache#14182) * update mkldnn to 0.17.x * update mkldnn to 0.17.4 * empty commit
* update mkldnn to 0.17.x * update mkldnn to 0.17.4 * empty commit
…ache#14182) * update mkldnn to 0.17.x * update mkldnn to 0.17.4 * empty commit
…ache#14182) * update mkldnn to 0.17.x * update mkldnn to 0.17.4 * empty commit
…ache#14182) * update mkldnn to 0.17.x * update mkldnn to 0.17.4 * empty commit
…ache#14182) * update mkldnn to 0.17.x * update mkldnn to 0.17.4 * empty commit
Description
Find the issue description at: https://lists.apache.org/thread.html/1d5883444907f0a06d711d1f482feeadcbe1d523e9944e953a26cf51@%3Cdev.mxnet.apache.org%3E
and
oneapi-src/oneDNN#405
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments