Doc Fix: added note about cuda9.2 requirement to Java example #14140
Conversation
| @@ -9,6 +9,8 @@ This command will pick the default values specified in the [pom](https://github. | |||
|
|
|||
| Note: If you are planning to use GPU, please add `-Dmxnet.profile=linux-x86_64-gpu` | |||
|
|
|||
| Note: The Maven package is built with CUDA 9.2. | |||
There was a problem hiding this comment.
Thanks Sam for bringing this up.
I think this is the correct location for this disclaimer : /~https://github.com/apache/incubator-mxnet/tree/master/scala-package#pre-built-maven-packages
There was a problem hiding this comment.
hmmm... I never looked at this page before. Maybe we should add a link and generalize the note more and say something like "Make sure you're environment is configured correctly according to..." and link to that page then?
Users following this demo arent necessarily going to read all the docs before running. We need to keep things self-containted and succinct.
|
@samskalicky Thanks for your contribution! @mxnet-label-bot add [pr-awaiting-review] |
|
@zachgk will the coverage results get uploaded to the codecov report that is generated for all of mxnet on CI runs? |
|
@samskalicky Can you please address the review comments ? Thanks! |
|
@samskalicky Ping for update! |
marcoabreu
added
pr-awaiting-response
|
@lanking520 @samskalicky @zachgk Can we take this PR to completion ? |
Description
example requires CUDA 9.2 but this wasnt mentioned anywhere in the instructions
Changes
Added note to clarify the CUDA 9.2 requirement