-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fixes libjpeg-turbo dependecy under Ubuntu 16.04 #14127
Conversation
bb99ce2
to
c6fc986
Compare
@perdasilva Thanks for your contribution! @mxnet-label-bot add [ pr-work-in-progress, build ] |
@mxnet-label-bot add [pr-awaiting-review] |
@mxnet-label-bot remove [pr-work-in-progress] |
Should we maybe only turn it on for a few builds to increase the diversity? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But makes sense to turn it on only for certain builds. Curious to know what's the compelling need for all of them?
I'm happy to have it only for certain ones. Do you guys have any suggestions based on your experience?
|
c6fc986
to
f90dfe5
Compare
* Fixes libjepgturbo dependency install on ubuntu * Enables libjpeg turbo on cpu build for testing
* Fixes libjepgturbo dependency install on ubuntu * Enables libjpeg turbo on cpu build for testing
* Fixes libjepgturbo dependency install on ubuntu * Enables libjpeg turbo on cpu build for testing
* Fixes libjepgturbo dependency install on ubuntu * Enables libjpeg turbo on cpu build for testing
* Fixes libjepgturbo dependency install on ubuntu * Enables libjpeg turbo on cpu build for testing
Description
Currently we cannot build mxnet on ubuntu 16.04 with USE_LIBJPEG_TURBO=1 because the library was compiled without PIC in the libturbo-jpeg library. Another package libjpegturbo fixes this issue.
see this.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Adds libjpeg-turbo dependency to ubuntu based builds appropriately.
Adds libjpeg-turbo flag to ubuntu builds. This is inline with the build flags used in the shipped version of mxnet, for instance, see this.
Now the CI and CD will be slightly more congruent.