This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Exclude concat layer for gpu quantization #14060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot add [pr-awaiting-review, Quantization] |
marcoabreu
added
pr-awaiting-review
PR is waiting for code review
Quantization
Issues/Feature Requests related to Quantization
labels
Feb 4, 2019
5 tasks
reminisce
approved these changes
Feb 5, 2019
pengzhao-intel
approved these changes
Feb 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wait for the CI pass.
@rajeshii could you help rebase the code and pass the CI?
@reminisce @pengzhao-intel CI pass now:) |
@reminisce could you help to take a look again and merge this PR? |
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
* exclude concat for gpu quantization * remove quantized_concat test in non-subgraph flow
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* exclude concat for gpu quantization * remove quantized_concat test in non-subgraph flow
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* exclude concat for gpu quantization * remove quantized_concat test in non-subgraph flow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
pr-awaiting-review
PR is waiting for code review
Quantization
Issues/Feature Requests related to Quantization
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exclude concat layer for gpu quantization since #13297 enable quantizaed_concat op for cpu.
below is the error log before this fix:
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments