This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
modifying SyncBN doc for FP16 use case #14041
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseth10
force-pushed
the
fix-doc-syncBN
branch
from
February 1, 2019 17:40
a610c07
to
83a76db
Compare
mseth10
force-pushed
the
fix-doc-syncBN
branch
from
February 4, 2019 21:42
83a76db
to
e5d7157
Compare
@mxnet-label-bot add [pr-awaiting-review, Doc] |
stu1130
approved these changes
Feb 5, 2019
vandanavk
approved these changes
Feb 5, 2019
@mxnet-label-bot update [pr-awaiting-merge, Doc] @aaronmarkham for review/merge |
marcoabreu
added
pr-awaiting-merge
Review and CI is complete. Ready to Merge
and removed
pr-awaiting-review
PR is waiting for code review
labels
Feb 5, 2019
lupesko
reviewed
Feb 5, 2019
We follow the sync-onece implmentation described in the paper [2]_. | ||
We follow the implementation described in the paper [2]_. | ||
|
||
Note: Current implementation of SyncBN does not support FP16 training. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So does it not support training or inference?
You say training in this line, and refer to inference in the next line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SyncBN does not have FP16 support for both training and inference. But for FP16 inference, SyncBN can be replaced with nn.BatchNorm as they have similar functionality.
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating docs to add instructions for MXNet users on SyncBN FP16 support and possible workarounds. This fixes #13976 .
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments