-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add back R tests and fix typo around R and perl tests #13940
Conversation
LGTM |
Seems like something isn't right:
Does somebody know from the top of their head what has to be done? Otherwise, I'm happy to have a look myself. |
I'm not sure what exactly caused the error. The error means R cannot find the dependencies. If they were just installed (seems so from the log), then I suggest to look for a mismatch in the environment, for instance: do the command which installed the dependencies, and the following |
ee49f9d
to
02b21ab
Compare
@@ -596,7 +596,7 @@ rpkg: | |||
cp -rf 3rdparty/dmlc-core/include/* R-package/inst/include/ | |||
cp -rf 3rdparty/tvm/nnvm/include/* R-package/inst/include | |||
Rscript -e "if(!require(devtools)){install.packages('devtools', repo = 'https://cloud.r-project.org/')}" | |||
Rscript -e "if(!require(devtools)||packageVersion('roxygen2') < '6.1.1'){install.packages('roxygen2', repo = 'https://cloud.r-project.org/')}" | |||
Rscript -e "if(!require(roxygen2)||packageVersion('roxygen2') < '6.1.1'){install.packages('roxygen2', repo = 'https://cloud.r-project.org/')}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremiedb could you double-check this please? You recently added this line and I assumed that it was a copy&paste leftover.
The result was that the script tried to query for the version of roxygen2 even if it was not installed, thus leading to a "null pointer exception".
* Add back R tests and fix typo around R and perl tests * Fix permissions * Fix copy&paste mistake around roxygen and remove previous permission override
* Add back R tests and fix typo around R and perl tests * Fix permissions * Fix copy&paste mistake around roxygen and remove previous permission override
* Add back R tests and fix typo around R and perl tests * Fix permissions * Fix copy&paste mistake around roxygen and remove previous permission override
This PR adds back the R tests that have been accidentally removed in my previous refactor. Sorry about that!!!
Also, I had a typo that mixed up Perl and R tests. Fixed that as well...
@jeremiedb @anirudhacharya @hetong007