Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1231] Allow not using Some in the Scala operators #13619

Merged
merged 8 commits into from
Jan 3, 2019
Merged

[MXNET-1231] Allow not using Some in the Scala operators #13619

merged 8 commits into from
Jan 3, 2019

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Dec 11, 2018 •
edited
Loading

Description

Adding a new Util called SomeConversion. Import that would help to reduce all Some usages.
@nswamy @yzhliu @andrewfayres @zachgk @piyushghai

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@roywei
Copy link
Member

roywei commented Dec 11, 2018

@lanking520 Thanks for the contribution! any documentation on how to use SomeConversion?
@mxnet-label-bot add[Scala, pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Scala labels Dec 11, 2018
zachgk
zachgk suggested changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@zachgk zachgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be changing docs/examples to use SomeConversion?

scala-package/core/src/test/scala/org/apache/mxnet/NDArraySuite.scala Show resolved Hide resolved
@lanking520 lanking520 force-pushed the allowSome branch 3 times, most recently from 6da10d4 to 01716c3 Compare December 14, 2018 22:47
zachgk
zachgk approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@zachgk zachgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yzhliu
yzhliu reviewed Dec 20, 2018
View reviewed changes
Copy link
Member

@yzhliu yzhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise good to me

scala-package/core/src/main/scala/org/apache/mxnet/util/SomeConversion.scala Outdated Show resolved Hide resolved
@Roshrini
Copy link
Member

Roshrini commented Jan 2, 2019

@lanking520 Can you retrigger CI?

@lanking520 lanking520 merged commit fe46cd9 into apache:master Jan 3, 2019
rondogency pushed a commit to rondogency/incubator-mxnet that referenced this pull request Jan 9, 2019
@lanking520
[MXNET-1231] Allow not using Some in the Scala operators (apache#13619)
8899385 
* add initial commit

* update image classifier as well

* create Util class make Some conversion

* add test changes

* adress Comments

* fix the spacing problem

* fix generator base

* change name to Option
@lanking520 lanking520 deleted the allowSome branch March 11, 2019 22:29
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@lanking520
[MXNET-1231] Allow not using Some in the Scala operators (apache#13619)
5eaa3ce 
* add initial commit

* update image classifier as well

* create Util class make Some conversion

* add test changes

* adress Comments

* fix the spacing problem

* fix generator base

* change name to Option
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Wei-1 Wei-1 Wei-1 left review comments

@yzhliu yzhliu yzhliu left review comments

@zachgk zachgk zachgk approved these changes

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review Scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lanking520 @roywei @Roshrini @yzhliu @zachgk @Wei-1 @marcoabreu