This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-1258]fix unittest for ROIAlign Operator #13609
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1be6c50
fix roi align test
wkcn aaa9d39
retrigger unittest
wkcn 6f3b55d
Merge branch 'master' of /~https://github.com/apache/incubator-mxnet in…
wkcn d0ada04
add more test detail for ROIAlign test
wkcn afcfe76
remove url in test_op_roi_align
wkcn b9e15a6
remove blank line in test_op_roi_align in test_operator
wkcn 7079f9a
Merge branch 'master' into fix_roi_align_test
wkcn 521eb5c
merge master
wkcn 6ab9233
merge master
wkcn 0c7dbe4
Update test_operator.py
wkcn 072b208
retrigger CI
wkcn 8698ae8
Merge branch 'fix_roi_align_test' of github.com:wkcn/incubator-mxnet …
wkcn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not typecast
x_low
tonp.float32
here itself and remove the many typecasting statements below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of x_low is
int
in the C implementation.In Python, the default type of float is
float64
, however the float type in the C implementation isfloat32
.If the types are not consistent, there will be calculation error.
So I use
T
to typecast some variables tonp.float32
to keep the type consistency between C and Python unittest.