-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Update version to v1.5.0 including clojure package #13566
Conversation
@nswamy , @lanking520, @gigasquid - PR validation failed in clojure build - http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-13566/1/pipeline . However, I have not changed clojure package version. What is the relationship between Scala and Clojure package version? Is there a manual push of scala packager required? |
Clojure issue - could just be a transient network issue. I've seen similar several times before:
|
Restart the job now |
There is a relation between the Clojure and Scala packages the Clojure CI tests build the Scala package, install it locally in maven, and then tries to build the package - since it is no longer building the 1.4.0 version but the 1.5.0 version - it will fail The minimum change that you need is in (defproject org.apache.mxnet.contrib.clojure/clojure-mxnet "1.5.0-SNAPSHOT"
:description "Clojure package for MXNet"
:url "/~https://github.com/apache/incubator-mxnet"
:license {:name "Apache License"
:url "http://www.apache.org/licenses/LICENSE-2.0"}
:dependencies [[org.clojure/clojure "1.9.0"]
[t6/from-scala "0.3.0"]
;; Jars from Nexus
;[org.apache.mxnet/mxnet-full_2.11-osx-x86_64-cpu "1.2.1"]
;[org.apache.mxnet/mxnet-full_2.11-linux-x86_64-cpu "1.2.1"]
;[org.apache.mxnet/mxnet-full_2.11-linux-x86_64-gpu "1.2.1"]
;;; CI
[org.apache.mxnet/mxnet-full_2.11-linux-x86_64-cpu "1.5.0-SNAPSHOT"]
[org.clojure/tools.logging "0.4.0"]
[org.apache.logging.log4j/log4j-core "2.8.1"]
[org.apache.logging.log4j/log4j-api "2.8.1"]
[org.slf4j/slf4j-log4j12 "1.7.25" :exclusions [org.slf4j/slf4j-api]]]
:pedantic? :skip
:plugins [[lein-codox "0.10.3" :exclusions [org.clojure/clojure]]
[lein-cloverage "1.0.10" :exclusions [org.clojure/clojure]]
[lein-cljfmt "0.5.7"]]
:codox {:namespaces [#"^org\.apache\.clojure-mxnet\.(?!gen).*"]}
:aot [dev.generator]
:repositories [["staging" {:url "https://repository.apache.org/content/repositories/staging"
;; If a repository contains releases only setting
;; :snapshots to false will speed up dependencies.
:snapshots true
;; Disable signing releases deployed to this repo.
;; (Not recommended.)
:sign-releases false
;; You can also set the policies for how to handle
;; :checksum failures to :fail, :warn, or :ignore.
:checksum :fail
;; How often should this repository be checked for
;; snapshot updates? (:daily, :always, or :never)
:update :always
;; You can also apply them to releases only:
:releases {:checksum :fail :update :always}}]]) I will follow on later tonight with a PR to update the rest of the Clojure package |
- add utility script to help bump versions in future - fix README to correct to current maven versions
I just pushed a branch /~https://github.com/apache/incubator-mxnet/tree/clojure-package-update-version-1.5.0 . If you merge this into your branch it should resolve the issues and update the Clojure package as well - or if you prefer, you can just update the project.clj and I'll do the rest as another PR. |
update version from 1.4.0 to 1.5.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go from the Clojure side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to Scala part!
@gigasquid - thanks Carin, including your branch resolved the PR check failures. Please review and merge the PR please. |
* Update DESCRIPTION * update version to v1.5.0 except for clojure * update version from 1.4.0 to 1.5.0 - add utility script to help bump versions in future - fix README to correct to current maven versions
* upstream/master: (54 commits) Add notes about debug with libstdc++ symbols (apache#13533) add cpp example inception to nightly test (apache#13534) Fix exception handling api doc (apache#13519) fix link for gluon model zoo (apache#13583) ONNX import/export: Size (apache#13112) Update MXNetTutorialTemplate.ipynb (apache#13568) fix the situation where idx didn't align with rec (apache#13550) Fix use-before-assignment in convert_dot (apache#13511) License update (apache#13565) Update version to v1.5.0 including clojure package (apache#13566) Fix flaky test test_random:test_randint_generator (apache#13498) Add workspace cleaning after job finished (apache#13490) Adding test for softmaxoutput (apache#13116) apache#13441 [Clojure] Add Spec Validations for the Random namespace (apache#13523) Revert "Bumped minor version from 1.4.0 to 1.5.0 on master, updated License file" (apache#13558) Chi_square_check for discrete distribution fix (apache#13543) Updated docs for randint operator (apache#13541) Simplifications and some fun stuff for the MNIST Gluon tutorial (apache#13094) Fix apache#13521 (apache#13537) Add a retry to qemu_provision (apache#13551) ...
Description
Update version to v1.5.0 except clojure package
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments