Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Clojure] Correct the versions in the README so they correspond to the latest maven.org release #13507

Merged
merged 5 commits into from
Dec 13, 2018
Merged

[Clojure] Correct the versions in the README so they correspond to the latest maven.org release #13507

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac7c46b
Correct the versions so they correspond to the latest maven.org release
gigasquid Dec 1, 2018
a4101ac
trigger build
gigasquid Dec 2, 2018
50fe73b
update README to be non-version specific
gigasquid Dec 6, 2018
3b1541c
merge master -fix conflicts
gigasquid Dec 11, 2018
91682ff
feedback from @kohr-h
gigasquid Dec 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions contrib/clojure-package/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ brew install opencv
- Create a new project with `lein new my-mxnet`
- Edit your `project.clj` and add one of the following entries to `:dependencies`, based on your system and the compute device you want to use:

- `[org.apache.mxnet.contrib.clojure/clojure-mxnet-linux-cpu "1.4.0"]`
- `[org.apache.mxnet.contrib.clojure/clojure-mxnet-linux-gpu "1.4.0"]`
- `[org.apache.mxnet.contrib.clojure/clojure-mxnet-osx-cpu "1.4.0"]`
- `[org.apache.mxnet.contrib.clojure/clojure-mxnet-linux-cpu "1.3.1"]`
- `[org.apache.mxnet.contrib.clojure/clojure-mxnet-linux-gpu "1.3.1"]`
- `[org.apache.mxnet.contrib.clojure/clojure-mxnet-osx-cpu "1.3.1"]`

After making this change and running `lein deps`, you should be able to run example code like this [NDArray Tutorial](/~https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/examples/tutorial/src/tutorial/ndarray.clj).

Expand All @@ -116,20 +116,20 @@ After making this change and running `lein deps`, you should be able to run exam
With this option, you will install a Git revision of the Clojure package source and a [Scala package jar from Maven](https://search.maven.org/search?q=g:org.apache.mxnet) with native dependencies baked in.

- Install additional dependencies as described in [the corresponding section for Option 1](#installing-additional-dependencies),
- Recursively clone the MXNet repository and checkout the desired revision. Here we assume the `1.4.0` tag and a clone into the `~/mxnet` directory:
- Recursively clone the MXNet repository and checkout the desired revision. Here we assume the `1.3.1` tag and a clone into the `~/mxnet` directory:

```bash
git clone --recursive /~https://github.com/apache/incubator-mxnet.git ~/mxnet
cd ~/mxnet
git tag --list # Find the tag that matches the Scala package version
git checkout tags/1.4.0 -b my_mxnet
git checkout tags/1.3.1 -b my_mxnet
git submodule update --init --recursive
cd contrib/clojure
```

- Edit `project.clj` to include the desired Scala jar from Maven:

[org.apache.mxnet/mxnet-full_2.11-linux-x86_64-cpu "1.4.0”]
[org.apache.mxnet/mxnet-full_2.11-linux-x86_64-cpu "1.3.1”]

- Run `lein test`. All the tests should run without error.
- At this point you can run `lein install` to build and install the Clojure jar locally.
Expand All @@ -147,7 +147,7 @@ The first step is to recursively clone the MXNet repository and checkout the des
```bash
git clone --recursive /~https://github.com/apache/incubator-mxnet.git ~/mxnet
cd ~/mxnet
git checkout tags/1.4.0 -b my_mxnet # this is optional
git checkout tags/1.3.1 -b my_mxnet # this is optional
git submodule update --init --recursive
```

Expand Down