Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-898] ONNX import/export: Sample_multinomial, ONNX export: GlobalLpPool, LpPool #13500

Merged
merged 5 commits into from
Jan 9, 2019
Merged

[MXNET-898] ONNX import/export: Sample_multinomial, ONNX export: GlobalLpPool, LpPool #13500

merged 5 commits into from
Jan 9, 2019
+158 −40

Conversation

vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Dec 1, 2018 •
edited
Loading

Description

ONNX export/import sample multinomial, ONNX export GlobalLpPool, LpPool

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Operator import/export
  • Test

Comments

@vandanavk vandanavk requested a review from szha as a code owner December 1, 2018 01:42
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot add [ONNX, pr-work-in-progress]

@marcoabreu marcoabreu added ONNX pr-work-in-progress PR is still work in progress labels Dec 1, 2018
@vandanavk vandanavk force-pushed the onnx_op branch 3 times, most recently from 263fa75 to aca5ee5 Compare December 11, 2018 02:30
@vandanavk vandanavk changed the title [WIP] ONNX import/export: Sample_multinomial ONNX import/export: Sample_multinomial Dec 11, 2018
@vandanavk vandanavk changed the title ONNX import/export: Sample_multinomial [MXNET-898] ONNX import/export: Sample_multinomial Dec 11, 2018
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot update [ONNX, pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels Dec 11, 2018
@vandanavk vandanavk changed the title [MXNET-898] ONNX import/export: Sample_multinomial [MXNET-898] ONNX import/export: Sample_multinomial, ONNX export: Gather Dec 11, 2018
@vandanavk vandanavk changed the title [MXNET-898] ONNX import/export: Sample_multinomial, ONNX export: Gather [MXNET-898] ONNX import/export: Sample_multinomial, ONNX export: Gather, GlobalLpPool, LpPool Dec 11, 2018
@vandanavk vandanavk force-pushed the onnx_op branch 3 times, most recently from a10ac50 to 1359835 Compare December 12, 2018 02:16
@vandanavk
Copy link
Contributor Author

@Roshrini @anirudhacharya @zhreshold for review

@vandanavk vandanavk force-pushed the onnx_op branch 2 times, most recently from 1eece51 to 866fae0 Compare December 19, 2018 18:18
@vandanavk vandanavk changed the title [MXNET-898] ONNX import/export: Sample_multinomial, ONNX export: Gather, GlobalLpPool, LpPool [MXNET-898] ONNX import/export: Sample_multinomial, ONNX export: GlobalLpPool, LpPool Dec 19, 2018
@Roshrini
Copy link
Member

Can you retrigger the CI?

@vandanavk vandanavk force-pushed the onnx_op branch 3 times, most recently from ed8db55 to 6dab15f Compare December 28, 2018 21:07
@Roshrini Roshrini merged commit 240f7ed into apache:master Jan 9, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@vandanavk
[MXNET-898] ONNX import/export: Sample_multinomial, ONNX export: Glob…
1cc25a8 
…alLpPool, LpPool (apache#13500)

* ONNX import/export: Sample_multinomial

* ONNX export: GlobalLpPool, LpPool

* Handle default p_value

* Add tests for multinomial, lppool, globallppool

* add a comment about shape test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Roshrini Roshrini Roshrini approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vandanavk @Roshrini @marcoabreu