Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-897] ONNX import/export: Size #13112

Merged
merged 1 commit into from
Dec 8, 2018
Merged

[MXNET-897] ONNX import/export: Size #13112

merged 1 commit into from
Dec 8, 2018

Conversation

vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Nov 5, 2018 •
edited
Loading

Description

Added support for importing/exporting Size to ONNX.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Import/export size
  • Add tests

Comments

@vandanavk vandanavk requested a review from szha as a code owner November 5, 2018 16:55
@ankkhedia
Copy link
Contributor

@mxnet-label-bot [pr-work-in-progress, ONNX]

@marcoabreu marcoabreu added ONNX pr-work-in-progress PR is still work in progress labels Nov 5, 2018
@kalyc
Copy link
Contributor

kalyc commented Nov 13, 2018

Thanks for your contribution @vandanavk
Any update on the PR?

@vandanavk vandanavk changed the title [WIP] ONNX import/export: Size ONNX import/export: Size Nov 26, 2018
@vandanavk vandanavk changed the title ONNX import/export: Size [MXNET-897] ONNX import/export: Size Nov 26, 2018
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot update [ONNX, pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels Nov 26, 2018
@nswamy
Copy link
Member

nswamy commented Dec 3, 2018

please rebase, @Roshrini @anirudhacharya for review ?

@vandanavk
Copy link
Contributor Author

@zhreshold for review

@nswamy nswamy merged commit 636933d into apache:master Dec 8, 2018
zhaoyao73 pushed a commit to zhaoyao73/incubator-mxnet that referenced this pull request Dec 13, 2018
@vandanavk @zhaoyao73
ONNX import/export: Size (apache#13112)
e08a4ac
zhaoyao73 added a commit to zhaoyao73/incubator-mxnet that referenced this pull request Dec 13, 2018
@zhaoyao73
Merge remote-tracking branch 'upstream/master'
79de25d 
* upstream/master: (54 commits)
  Add notes about debug with libstdc++ symbols (apache#13533)
  add cpp example inception to nightly test (apache#13534)
  Fix exception handling api doc (apache#13519)
  fix link for gluon model zoo (apache#13583)
  ONNX import/export: Size (apache#13112)
  Update MXNetTutorialTemplate.ipynb (apache#13568)
  fix the situation where idx didn't align with rec (apache#13550)
  Fix use-before-assignment in convert_dot (apache#13511)
  License update  (apache#13565)
  Update version to v1.5.0 including clojure package (apache#13566)
  Fix flaky test test_random:test_randint_generator (apache#13498)
  Add workspace cleaning after job finished (apache#13490)
  Adding test for softmaxoutput (apache#13116)
  apache#13441 [Clojure] Add Spec Validations for the Random namespace (apache#13523)
  Revert "Bumped minor version from 1.4.0 to 1.5.0 on master, updated License file" (apache#13558)
  Chi_square_check for discrete distribution fix (apache#13543)
  Updated docs for randint operator (apache#13541)
  Simplifications and some fun stuff for the MNIST Gluon tutorial (apache#13094)
  Fix apache#13521 (apache#13537)
  Add a retry to qemu_provision (apache#13551)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Roshrini Roshrini Roshrini approved these changes

@zhreshold zhreshold zhreshold approved these changes

@anirudhacharya anirudhacharya anirudhacharya approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vandanavk @ankkhedia @kalyc @nswamy @anirudhacharya @zhreshold @Roshrini @marcoabreu