Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Revert "update dmlc-core (#12129)" #12173

Closed
wants to merge 2 commits into from
Closed

Revert "update dmlc-core (#12129)" #12173

wants to merge 2 commits into from

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Aug 15, 2018

Description

Reverts #12129

This is to circumvent double free memory error in #12139. The memory error has been inside CSVIter but remained undetected until a recent modification of CSVParser.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Revert dmlc-core to last working point

Comments

  • This is a temporary measure. We'll need to come back to CSVIter and address memory error. Address Sanitizer reveals double free issues in CSVIter.

@haojin2
Copy link
Contributor

haojin2 commented Aug 15, 2018

@marcoabreu The build for this PR has passed but the status is not reflected on this page, can you take a look?

@hcho3 hcho3 closed this Aug 15, 2018
@hcho3 hcho3 deleted the revert-dmlc-core branch August 15, 2018 19:17
@hcho3
Copy link
Contributor Author

hcho3 commented Aug 15, 2018

Closing this now. I'll submit a new pull request where individual commits from dmlc-core are cherry-picked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants