-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth Manager API part 2: AuthManager #11809
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fdd1941
Auth Manager API part 2: AuthManager, AuthSession
adutra 28db239
[review] close()
adutra df4243b
[review] nits
adutra e3c4b31
HTTPAuthSession close()
adutra 52f4423
mainSession -> catalogSession
adutra 2a3f4af
AuthManager constructor
adutra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
HTTPAuthSession close()
- Loading branch information
commit e3c4b311de21194ac82e4c450cb72d9f393beba3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,16 @@ | |
public interface AuthSession extends AutoCloseable { | ||
|
||
/** An empty session that does nothing. */ | ||
AuthSession EMPTY = request -> request; | ||
AuthSession EMPTY = | ||
new AuthSession() { | ||
@Override | ||
public HTTPRequest authenticate(HTTPRequest request) { | ||
return request; | ||
} | ||
|
||
@Override | ||
public void close() {} | ||
}; | ||
|
||
/** | ||
* Authenticates the given request and returns a new request with the necessary authentication. | ||
|
@@ -44,7 +53,5 @@ public interface AuthSession extends AutoCloseable { | |
* the cache, or the cache itself is closed. | ||
*/ | ||
@Override | ||
default void close() { | ||
// Do nothing | ||
} | ||
void close(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @nastra per your previous comment, I thought you would prefer this method to be non-default as well. |
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming issue from the previous PR is still pending. @nastra and myself agreed recently on
HTTPAuthSession
– @danielcweeks is that OK with you?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked with @danielcweeks and we probably want to go with what you have here as we should eventually deprecate the
AuthSession
inOAuth2Util
and so we shouldn't have an issue with conflicting names for too long