-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4938]feat(lakehouse-paimon): Support S3 filesystem for Paimon catalog. #4939
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
6180ed6
Support S3 filesystem for Paimon catalog.
yuqi1129 69e8b28
Fix
yuqi1129 1ff547a
Fix
yuqi1129 f9bf3c1
Add some document.
yuqi1129 fe2cc8f
fix
yuqi1129 48149dd
fix test error.
yuqi1129 71e7551
Merge branch 'main' of github.com:apache/gravitino into issue_4938
yuqi1129 6b040e7
FIX
yuqi1129 1836a32
Fix test error in deploy mode.
yuqi1129 faf5e59
Fix
yuqi1129 acd6b1a
Merge branch 'main' of github.com:apache/gravitino into issue_4938
yuqi1129 56358cb
Resolve comments
yuqi1129 4229cdb
forget to push file S3StorageConfig
yuqi1129 04bf3d6
Merge branch 'issue_4938' of github.com:yuqi1129/gravitino into issue…
yuqi1129 dfcb374
Merge branch 'main' of github.com:datastrato/graviton into issue_4938
yuqi1129 6daf940
Merge branch 'issue_4938' of github.com:yuqi1129/gravitino into issue…
yuqi1129 3c21686
Fix
yuqi1129 49f9ac3
Fix
yuqi1129 6135e7e
Fix
yuqi1129 f5a2a30
Merge branch 'main' of github.com:datastrato/graviton into issue_4938
yuqi1129 15e6ca9
fix
yuqi1129 d68bd65
Merge branch 'main' of github.com:datastrato/graviton into issue_4938
yuqi1129 df823d9
Fix
yuqi1129 c705667
Removed unused class.
yuqi1129 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
105 changes: 105 additions & 0 deletions
105
.../src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/storage/S3StorageConfig.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.apache.gravitino.catalog.lakehouse.paimon.storage; | ||
|
||
import static org.apache.gravitino.storage.S3Properties.GRAVITINO_S3_ACCESS_KEY_ID; | ||
import static org.apache.gravitino.storage.S3Properties.GRAVITINO_S3_ENDPOINT; | ||
import static org.apache.gravitino.storage.S3Properties.GRAVITINO_S3_SECRET_ACCESS_KEY; | ||
|
||
import com.google.common.collect.ImmutableMap; | ||
import java.util.Map; | ||
import org.apache.commons.lang3.StringUtils; | ||
import org.apache.gravitino.Config; | ||
import org.apache.gravitino.config.ConfigBuilder; | ||
import org.apache.gravitino.config.ConfigConstants; | ||
import org.apache.gravitino.config.ConfigEntry; | ||
import org.apache.gravitino.connector.PropertyEntry; | ||
|
||
public class S3StorageConfig extends Config { | ||
|
||
public S3StorageConfig(Map<String, String> properties) { | ||
super(false); | ||
loadFromMap(properties, k -> true); | ||
} | ||
|
||
// Unified S3 | ||
public static final ConfigEntry<String> PAIMON_S3_ENDPOINT_ENTRY = | ||
new ConfigBuilder(GRAVITINO_S3_ENDPOINT) | ||
.doc("The endpoint of the AWS s3") | ||
.version(ConfigConstants.VERSION_0_7_0) | ||
.stringConf() | ||
.checkValue(StringUtils::isNotBlank, ConfigConstants.NOT_BLANK_ERROR_MSG) | ||
.create(); | ||
|
||
public static final ConfigEntry<String> PAIMON_S3_ACCESS_KEY_ENTRY = | ||
new ConfigBuilder(GRAVITINO_S3_ACCESS_KEY_ID) | ||
.doc("The access key of the AWS s3") | ||
.version(ConfigConstants.VERSION_0_7_0) | ||
.stringConf() | ||
.checkValue(StringUtils::isNotBlank, ConfigConstants.NOT_BLANK_ERROR_MSG) | ||
.create(); | ||
|
||
public static final ConfigEntry<String> PAIMON_S3_SECRET_KEY_ENTRY = | ||
new ConfigBuilder(GRAVITINO_S3_SECRET_ACCESS_KEY) | ||
.doc("The secret key of the AWS s3") | ||
.version(ConfigConstants.VERSION_0_7_0) | ||
.stringConf() | ||
.checkValue(StringUtils::isNotBlank, ConfigConstants.NOT_BLANK_ERROR_MSG) | ||
.create(); | ||
|
||
public String getS3Endpoint() { | ||
return get(PAIMON_S3_ENDPOINT_ENTRY); | ||
} | ||
|
||
public String getS3AccessKey() { | ||
return get(PAIMON_S3_ACCESS_KEY_ENTRY); | ||
} | ||
|
||
public String getS3SecretKey() { | ||
return get(PAIMON_S3_SECRET_KEY_ENTRY); | ||
} | ||
|
||
public static final Map<String, PropertyEntry<?>> S3_FILESYSTEM_PROPERTY_ENTRIES = | ||
new ImmutableMap.Builder<String, PropertyEntry<?>>() | ||
.put( | ||
GRAVITINO_S3_ENDPOINT, | ||
PropertyEntry.stringOptionalPropertyEntry( | ||
GRAVITINO_S3_ENDPOINT, | ||
"The endpoint of the AWS s3", | ||
false /* immutable */, | ||
null /* defaultValue */, | ||
false /* hidden */)) | ||
.put( | ||
GRAVITINO_S3_ACCESS_KEY_ID, | ||
PropertyEntry.stringOptionalPropertyEntry( | ||
GRAVITINO_S3_ACCESS_KEY_ID, | ||
"The access key of the AWS s3", | ||
false /* immutable */, | ||
null /* defaultValue */, | ||
false /* hidden */)) | ||
.put( | ||
GRAVITINO_S3_SECRET_ACCESS_KEY, | ||
PropertyEntry.stringOptionalPropertyEntry( | ||
GRAVITINO_S3_SECRET_ACCESS_KEY, | ||
"The secret key of the AWS s3", | ||
false /* immutable */, | ||
null /* defaultValue */, | ||
false /* hidden */)) | ||
.build(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we consider s3 region?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the doc provided by Paimon,
region
is excessive.