[#3587] feat(trino-connector): Support create Internal connector like hive/iceberg/mysql/pg/memory #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Support create gravitino catalog by CREATE CATALOG statement
yuqi1129
reviewed
May 27, 2024
.../src/main/java/com/datastrato/gravitino/trino/connector/GravitinoConnectorPluginManager.java
Show resolved
Hide resolved
.../src/main/java/com/datastrato/gravitino/trino/connector/GravitinoConnectorPluginManager.java
Outdated
Show resolved
Hide resolved
|
|
||
| // Load all plugins | ||
| for (String pluginName : usePlugins) { | ||
| loadPlugin(pluginDir, pluginName); |
There was a problem hiding this comment.
It seems that we will omit the left catalogs if any of them fails to load.
There was a problem hiding this comment.
I think if the connector plugin fails to load, the Trino server should fail during startup.
.../src/main/java/com/datastrato/gravitino/trino/connector/GravitinoConnectorPluginManager.java
Outdated
Show resolved
Hide resolved
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
May 30, 2024
…r like hive/iceberg/mysql/pg/memory (apache#3588) ### What changes were proposed in this pull request? Support create Internal connector like hive/iceberg/mysql/pg/memory ### Why are the changes needed? Fix: apache#3587 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? NO
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
May 30, 2024
…r like hive/iceberg/mysql/pg/memory (apache#3588) ### What changes were proposed in this pull request? Support create Internal connector like hive/iceberg/mysql/pg/memory ### Why are the changes needed? Fix: apache#3587 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? NO
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…r like hive/iceberg/mysql/pg/memory (apache#3588) ### What changes were proposed in this pull request? Support create Internal connector like hive/iceberg/mysql/pg/memory ### Why are the changes needed? Fix: apache#3587 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? NO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support create Internal connector like hive/iceberg/mysql/pg/memory
Why are the changes needed?
Fix: #3587
Does this PR introduce any user-facing change?
NO
How was this patch tested?
NO